Open
Conversation
✅ Deploy Preview for vue-router-docs-v3 canceled.
|
946af17 to
3a5a7f2
Compare
- Updated TypeScript and Flow type definitions to properly handle null values in query parameters - Added dedicated type tests to verify query parameter scenarios Fixes vuejs#3566
3a5a7f2 to
c49c3dc
Compare
Author
|
After 3 retries here is what I have done @posva can you please have a look |
Member
|
Thanks but same as in the other PR 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3566
Updated typedef of interface Route from:
query: Dictionary<string | (string | null)[]>
to:
query: Dictionary<string | null | (string | null)[]>
Changes made:
This change ensures proper typing for query parameters that don't have any value, while maintaining backward compatibility.