Skip to content

just use portfinder when user not set port #3787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

just use portfinder when user not set port #3787

wants to merge 2 commits into from

Conversation

xsbchen
Copy link
Contributor

@xsbchen xsbchen commented Apr 10, 2019

fix #3719

@LinusBorg
Copy link
Member

This will result in a cryptic error if the user-specified port is not free.

Which is why we still run portfinde even if the user provided a port.

This PR would at least have to provide a decent error handling & console message.

@xsbchen
Copy link
Contributor Author

xsbchen commented Apr 10, 2019

@LinusBorg added!

@PanJiaChen
Copy link
Contributor

image

Maybe this kind of interaction is better?

@LinusBorg LinusBorg mentioned this pull request May 7, 2019
Open
@IndexXuan
Copy link
Contributor

any further ? It should give options to not use find porter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Breaking Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

export the port
5 participants
@xsbchen @LinusBorg @PanJiaChen @IndexXuan @haoqunjiang