feat(theme): allow joining attr to external link#5123
Open
WizardsBowl wants to merge 1 commit intovuejs:mainfrom
Open
feat(theme): allow joining attr to external link#5123WizardsBowl wants to merge 1 commit intovuejs:mainfrom
WizardsBowl wants to merge 1 commit intovuejs:mainfrom
Conversation
15a0278 to
09af6c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I tried to add
rel="nofollow"attribute to an external link and found it doesn't work.My markdown file is like this:
And this is the final html:
It's
relattribute is an unexpected noreferrer but not nofollow.That's because the
linkPluginalways useattrSetand override the old value.This PR add an option telling the
linkPluginto useattrSetor to useattrJoinfor each attr.The final html contains both nofollow and noreferrer:
Linked Issues
None.
Additional Context
The markdown-it-attrs plugin is built-in with VitePress.
Tip
The author of this PR can publish a preview release by commenting
/publishbelow.