-
-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(vscode): use unjs/unbuild
for bundling
#4998
base: master
Are you sure you want to change the base?
Conversation
vue-component-meta
vue-component-type-helpers
@vue/language-plugin-pug
@vue/language-server
@vue/language-service
@vue/language-core
vue-tsc
@vue/typescript-plugin
commit: |
unjs/unbuild
for bundling
Hey, what do you think about switching to tsdown, powered by Rolldown, for faster speed? |
…uce bundle size (vuejs#5054) Co-authored-by: Johnson Chu <[email protected]>
ae194a1
to
940b97c
Compare
…language-tools into chore/use-unbuild
… chore/use-unbuild
@@ -573,7 +574,9 @@ | |||
"esbuild": "latest", | |||
"esbuild-visualizer": "latest", | |||
"reactive-vscode": "^0.2.9", | |||
"rollup-plugin-visualizer": "^5.12.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that you've replaced sonda
with rollup-plugin-visualizer
. I will not try to convince you to use sonda
, but if this was a technical decision, could you share the reason? I would appreciate your feedback so I can improve it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnsoncodehk uwu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @filipsobol, first of all thank you for developing sonda. One of the reasons is that we want the PR to keep the most relevant changes so that it has a greater chance of being merged. Another reason is that the output file treemap is paginated in Sonda, and we cannot visually check whether the modules that need to be shared by multiple files have been correctly split.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this gives me some interesting ideas 🤔
Another reason is that the output file treemap is paginated in Sonda, and we cannot visually check whether the modules that need to be shared by multiple files have been correctly split.
By visual check, do you mean manual or automated visual check? You should be able to switch between chunks using the dropdown menu in the upper-left corner, but I can imagine that it may require extra work or even problems in automated tests (e.g. if it visually compares two reports).
c3e80dc
to
209717c
Compare
Use https://github.com/unjs/unbuild to bundle the VSCode extension, also as a preparation for #4994.
Notes:
pnpm dev:vue
, the command will exit after the stub files generated (no need to watch file changes), then F5. (Should the tasks defined in.vscode/tasks.json
and.vscode/launch.json
be restored?)