ci: simplify CI matrix and more comprehensive tests #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng pnpm-workspace.yaml
as ts tries to search upwards and found the depended `tsconfig/node22` dep missing
This reverts commit 04af4bb. It would took too much effort to make it work. We can revisit it later. It's never tested before anyway.
haoqunjiang
changed the title
…t comprehensive yet
cexbrayat
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify the CI pipeline for a cleaner workflow; and avoid the parallelism limit when we add more flags to the CLI.
Most of the time, the new workflow's total duration would be shorter or similar to the previous one (longer job execution time but less queueing time1), but sometimes, Windows Cypress tests took too long when cache misses.
TODOs:
typescript-*projects from others because type-checking takes much more timeadd tests for NightwatchI didn't manage to get Nightwatch tests working on GitHub Actions. It was never tested before anyway, so let's skip that for this PR.I'd like to move that into a separate PR because it requires changing the snapshot script, so not a mere CI change.
--with-tests. That should also be a separate PR.TO DECIDE:
engine-strictflag on? Because most of the actual compatibility work is on the shoulder of the upstream projects, not us.Footnotes
there can be only 20 concurrent jobs on GitHub Free plan ↩