Skip to content

fix(runtime-vapor): render slot fallback if provided content is invalid #13669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: minor
Choose a base branch
from

Conversation

edison1105
Copy link
Member

close #13668

Copy link

coderabbitai bot commented Jul 21, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/fix/vaporSlotFallback

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Jul 21, 2025

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84 kB 29.8 kB 26.3 kB
runtime-dom.global.prod.js 104 kB 39.1 kB 35.3 kB
vue.global.prod.js 162 kB 59.3 kB 52.8 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB 18.4 kB 16.9 kB
createApp 56 kB 21.6 kB 19.7 kB
createApp + vaporInteropPlugin 69.1 kB (+458 B) 26 kB (+122 B) 23.7 kB (+117 B)
createVaporApp 21.3 kB (+456 B) 8.39 kB (+130 B) 7.7 kB (+125 B)
createSSRApp 60.3 kB 23.3 kB 21.3 kB
defineCustomElement 61 kB 23.1 kB 21.1 kB
overall 70.5 kB 26.8 kB 24.5 kB

Copy link

pkg-pr-new bot commented Jul 21, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13669

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13669

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13669

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13669

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13669

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13669

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13669

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13669

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13669

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13669

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13669

vue

npm i https://pkg.pr.new/vue@13669

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13669

commit: 046add8

@edison1105 edison1105 force-pushed the edison/fix/vaporSlotFallback branch 2 times, most recently from d1ff736 to 36343f9 Compare July 21, 2025 00:39
@edison1105 edison1105 marked this pull request as draft July 21, 2025 01:02
@edison1105 edison1105 force-pushed the edison/fix/vaporSlotFallback branch from 36343f9 to 8602be2 Compare July 21, 2025 01:23
@edison1105 edison1105 marked this pull request as ready for review July 21, 2025 01:24
@edison1105 edison1105 added the scope: vapor related to vapor mode label Jul 21, 2025
@edison1105 edison1105 moved this to Vapor in Next Minor Jul 21, 2025
@edison1105 edison1105 force-pushed the edison/fix/vaporSlotFallback branch from 8602be2 to b498eec Compare July 21, 2025 09:25
@edison1105 edison1105 force-pushed the edison/fix/vaporSlotFallback branch from b498eec to 2ba4dc0 Compare July 21, 2025 12:48
@edison1105 edison1105 changed the title fix(runtime-vapor): render slot fallback if slot content is not a valid block fix(runtime-vapor): properly render slot fallback if slot content is not a valid block Jul 22, 2025
@edison1105 edison1105 force-pushed the edison/fix/vaporSlotFallback branch from e17e936 to 5941507 Compare July 22, 2025 05:49
@edison1105 edison1105 force-pushed the edison/fix/vaporSlotFallback branch from 5941507 to e28b96b Compare July 22, 2025 05:56
@edison1105 edison1105 marked this pull request as draft July 23, 2025 08:47
@edison1105 edison1105 force-pushed the edison/fix/vaporSlotFallback branch from dd31140 to c38636c Compare July 23, 2025 13:07
@edison1105 edison1105 force-pushed the edison/fix/vaporSlotFallback branch from c38636c to a65da3a Compare July 23, 2025 13:44
@edison1105 edison1105 marked this pull request as ready for review July 23, 2025 14:07
Copy link
Contributor

@alex-snezhko alex-snezhko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edison1105 edison1105 force-pushed the edison/fix/vaporSlotFallback branch from 5c6e533 to 3a52e46 Compare July 25, 2025 14:17
@edison1105 edison1105 changed the title fix(runtime-vapor): properly render slot fallback if slot content is not a valid block fix(runtime-vapor): render slot fallback if slot content is invalid Jul 25, 2025
@edison1105 edison1105 changed the title fix(runtime-vapor): render slot fallback if slot content is invalid fix(runtime-vapor): render slot fallback if provided content is invalid Jul 25, 2025
@edison1105 edison1105 moved this from Vapor to In Progress in Next Minor Aug 20, 2025
Copy link
Member

@LittleSound LittleSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playground

The current implementation cannot support the above situation.
recommended to add a non-rendering related state to Fragment. Implement this feature by maintaining that state.

@edison1105 edison1105 marked this pull request as draft August 20, 2025 12:29
@edison1105 edison1105 marked this pull request as ready for review August 22, 2025 07:42
@edison1105
Copy link
Member Author

Playground

The current implementation cannot support the above situation. recommended to add a non-rendering related state to Fragment. Implement this feature by maintaining that state.

fixed in #13408 see d7a7672

Copy link

netlify bot commented Aug 22, 2025

Deploy Preview for vue-sfc-playground failed. Why did it fail? →

Name Link
🔨 Latest commit 4a5de8c
🔍 Latest deploy log https://app.netlify.com/projects/vue-sfc-playground/deploys/68a8223891b06c00083a8bc3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: vapor related to vapor mode
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

[Vapor] fallback slot content not rendered if content is comment
3 participants