fix(reactivity): add warning for array operations on null/undefined v… #12732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alues Enhance the MutableReactiveHandler to include a development-only warning when attempting to perform operations on null or undefined values in arrays. This change aims to prevent unexpected behavior during reactive state management.
edison1105
reviewed
Jan 17, 2025
| !Number.isNaN(Number(key)) | ||
| ) { | ||
| const targetValue = target[key as keyof typeof target] | ||
| if (targetValue === null || targetValue === undefined) { |
There was a problem hiding this comment.
Suggested change
| if (targetValue === null || targetValue === undefined) { | |
| if (targetValue == null) { |
|
Could you please add a test for this? |
|
I'm unclear what problem this warning is trying to solve. Code like this triggers the warning: const msg = reactive([])
msg[0] = 7That seems like normal usage to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…alues
Enhance the MutableReactiveHandler to include a development-only warning when attempting to perform operations on null or undefined values in arrays. This change aims to prevent unexpected behavior during reactive state management.