-
Notifications
You must be signed in to change notification settings - Fork 4.4k
[WIP] Update: add htmlhint #758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should we provide a Edit: Just read https://github.com/yaniswang/HTMLHint/wiki/Usage#how-to-use and saw if
Seems reasonable but maybe we should have a comment with a link to that page? Or to: https://github.com/yaniswang/HTMLHint/wiki/Rules |
Also, should this be an option together with ESLint or should it be a separate option during vue-cli init time? I'm not sure which is better to be honest. Thoughts anyone? |
@aladdin-add, @maxmilton, I think having a separate option would be better than combining it with eslint since the whole vue ecosystem is non-opinionated and highly configurable, even tho I think nobody will use just one of them. |
template/build/webpack.base.conf.js
Outdated
enforce: 'pre', | ||
loader: 'htmlhint-loader', | ||
exclude: /node_modules/ | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be wrapped in {{#lint}}...{{/lint}}
just like eslint-loader
or have another key in meta.js
something like htmlLint
template/package.json
Outdated
@@ -37,6 +37,7 @@ | |||
"eslint-friendly-formatter": "^2.0.7", | |||
"eslint-loader": "^1.7.1", | |||
"eslint-plugin-html": "^2.0.0", | |||
"htmlhint-loader": "1.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above comment
I think, just like @maxmilton said, there should be |
Looks like there might soon be a solution for the blank error in |
fixes #210