Fix arc4 compilation debian #343
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
force-pushed
the
main
branch
2 times, most recently
from
fcf9b65 to
a22b0ea
Compare
vszakats
requested changes
Jan 23, 2025
contrib/hbfbird/firebird.c
Outdated
| @@ -149,41 +149,42 @@ HB_FUNC( FBCREATEDB ) | |||
| hb_retnl( 0 ); | |||
| } | |||
|
|
|||
| HB_FUNC( FBCONNECT ) | |||
| HB_FUNC(FBCONNECT) | |||
There was a problem hiding this comment.
It'd make it easier to review and merge without formatting/comment changes to existing code.
contrib/hbfbird/firebird.c
Outdated
| len = (int)(sizeof(dpb) - i - 2); | ||
| i += hb_snprintf(dpb + i, sizeof(dpb) - i, "%c", (char)len); | ||
| hb_strncpy(&(dpb[i]), passwd, len); | ||
| i += (short)len; |
There was a problem hiding this comment.
Can the above hb_snprintf() calls be made fewer or into a single one?
There was a problem hiding this comment.
Pushed a fix for this that uses a single call. Untested.
contrib/hbnf/setdate.c
Outdated
| @@ -1,4 +1,5 @@ | |||
| /* Rewritten in 2012 by Viktor Szakats and kept in the | |||
| /* | |||
| * Rewritten in 2012 by Viktor Szakats and kept in the | |||
contrib/hbnf/settime.c
Outdated
| @@ -1,4 +1,5 @@ | |||
| /* Rewritten in 2012 by Viktor Szakats and kept in the | |||
| /* | |||
| * Rewritten in 2012 by Viktor Szakats and kept in the | |||
contrib/hbtest/core.prg
Outdated
| cLangOld := hb_langSelect( "en" ) /* to always have RTEs in one language */ | ||
|
|
||
|
|
||
| cLangOld := __hb_langSelect( "en" ) /* to always have RTEs in one language */ |
| } | ||
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
nit: Missing standard indentation and extra lines.
contrib/hbnf/settime.c
Outdated
| ts.tv_sec = mktime(tm_info); | ||
| ts.tv_nsec = 0; | ||
|
|
||
| fResult = clock_settime(CLOCK_REALTIME, &ts) == 0; |
contrib/hbct/dattime3.c
Outdated
| ts.tv_sec = mktime(tm_info); | ||
| ts.tv_nsec = 0; | ||
|
|
||
| fResult = clock_settime(CLOCK_REALTIME, &ts) == 0; |
There was a problem hiding this comment.
I have a patch for this, but it doesn't apply, not sure why.
vszakats
added a commit
that referenced
this pull request
Jan 23, 2025
Limited build-test only. Ref: #343
added 4 commits
March 22, 2025 17:46
- Replaced hb_langSelect with __hb_langSelect to prevent crashes during repetitive tests.
Revert to previous version of: contrib/hbtest/tests/test.prg
endaco
force-pushed
the
fix-arc4-compilation-debian
branch
from
e38785b to
e8e6ddc
Compare
vszakats
reviewed
Mar 22, 2025
contrib/hbfbird/firebird.c
Outdated
| hb_retnl(isc_sqlcode(status)); | ||
| else | ||
| hb_FB_db_handle_ret(db); | ||
| return; |
There was a problem hiding this comment.
Please keep existing formatting, indentation. It helps to see and understand the code changes you made.
endaco
force-pushed
the
fix-arc4-compilation-debian
branch
from
49b224e to
ab22db0
Compare
|
Thanks! Formatting adjustments applied as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This Pull Request addresses and fixes various compilation issues on Debian 12 systems related to ARC4 and time/date functions
Changes Made
arc4.c:
settime.c:
setdate.c:
dattime3.c:
firebird.c:
hb_snprintfto prevent possible buffer overflow issues.Impact
These changes ensure that the code compiles correctly and operates smoothly on Debian 12 systems.
Tests Conducted