-
Notifications
You must be signed in to change notification settings - Fork 269
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
4 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee52a85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sourcepackage for this release is missing the wxwidgets submodule ... (maybe something to mention in the readme?)
ee52a85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, GitHub-generated source packages never contain submodules. This is how GitHub works and it has nothing to do with WinSparkle or this specific release; every release on GitHub is the same.
Just use a git checkout.
You do have a point about the README, though, thanks for bringing that up — that’s horribly out of date. I’ll update it to explain that compilation from sources must be done from a git checkout.
ee52a85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it also works fine to download the tarball from the submodule with the tagged revision and put it into the proper dir before compiling ;)