Added support for Lightroom Classic CC on OSX #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If people are happy with this PR, could we merge it so that others will be able to download it? (I'm guessing only someone from VSCO can merge this) |
|
THANK YOU THANK YOU THANK YOU!!! |
|
This looks good, thank you @cajames we'll merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed that LR Classic CC broke the build, so I've added the fix for OSX. #28
I haven't got a Windows machine to do the fix for Windows atm, but I'll try help out soon if no-one else does, and people want it.
In the meantime, if people want to download the new installer for OSX, you can here: https://github.com/cajames/keys/releases/tag/v2.0.1