Basic Groups API #197
Merged
Basic Groups API #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foorack
requested changes
Dec 1, 2022
There was a problem hiding this comment.
Fantastic job from both @ariesclark and @Miner28 !!
Please look at the comments for further feedback.
Closed
Foorack
reviewed
Dec 1, 2022
This reverts commit 0c1592d.
|
👏 looks awesome so far :) |
ariesclark
reviewed
Dec 2, 2022
ariesclark
requested changes
Dec 2, 2022
Foorack
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
This PR does not entirely solve #198 , but nor do I think it should. This is a good starting point for documenting the Group API, due to it's size. I would be happy to merge this now in the current state it is in.
Just because we merge something into main does not mean it goes into live. For that we need to create a Release, so don't worry, we can develop on main as long as tests pass.
Thanks for fantastic work everyone! ❤️ @Miner28 @ariesclark I think this is the best real-time API documentation collaboration I have seen in a long time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #198