Skip to content

Update README and metadata to remove official PE and Puppet Core support #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nmburgan
Copy link

Pull Request (PR) description

Update the readme and metadata to show we can no longer support PE or Puppet Core

This Pull Request (PR) fixes the following issues

n/a

@@ -18,10 +18,6 @@
}
],
"requirements": [
{
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also remove the forge showing it is supported for PE, as it has an internal table it uses to map Puppet to PE support.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewers: I will remove this before merging for now, until we've got the Facter fork ready and we're comfortable removing it.

Copy link
Contributor

@genebean genebean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. FWIW, there is an archive of that page in case they pull it or change it:
https://web.archive.org/web/20250416004958/https://www.puppet.com/blog/open-source-puppet-updates-2025

Copy link
Member

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need a PR title that reflects this change. And we need to discuss if this is a major change or not. We usually did major releases for dropping a end of life puppet version.. And it would help if we would actually test against our facter version.

@nmburgan
Copy link
Author

Good call. Yeah, we should figure out if we need to major rev it, and hopefully we can get a facter-new gem out soon.

@nmburgan nmburgan changed the title Update README and metadata Update README and metadata to remove official PE and Puppet Core support Jun 11, 2025
@bastelfreak
Copy link
Member

bastelfreak commented Jun 11, 2025

Next step for facter: finding a new name: OpenVoxProject/openfact#12

Afterwards we can release it. That shouldn't take too long.

  • get name for facter
  • release facter
  • update and release rspec-puppet-facts to use our facter
  • update and release openvox to use our facter

@nmburgan nmburgan added the needs-feedback Further information is requested label Jun 11, 2025
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning language is well phrased and appropriate.

@tuxmea
Copy link
Member

tuxmea commented Jun 16, 2025

Do we really want to annoy users by specifying that a module is no longer "supported" to work on PE/PC?
I would prefer to say that we "can no longer verify functionality on PE/PC" and that additional testing is required.

It sound less harsh and might motivate people to move from PE/PC to OpenVox.
If we just say "no support", people might not doing updates anymore or build something by themselves.

Co-authored-by: Kenyon Ralph <[email protected]>
@nmburgan
Copy link
Author

Do we really want to annoy users by specifying that a module is no longer "supported" to work on PE/PC? I would prefer to say that we "can no longer verify functionality on PE/PC" and that additional testing is required.

It sound less harsh and might motivate people to move from PE/PC to OpenVox. If we just say "no support", people might not doing updates anymore or build something by themselves.

To me, those two things are equivalent. I personally prefer the stronger language to make it very clear that if you run into a problem with this in PE/PC, there's probably not much we can do about it (guessing a solution without being able to test it is not a good strategy). I also think the stronger language would make people more likely to move to OpenVox in order to get support, but perhaps that's true. But I also take your point that it may lead to people sticking with an old version and never updating. If people would like the softer language, I can change it.

@sehrkamp
Copy link

sehrkamp commented Jun 17, 2025

Do we really want to annoy users by specifying that a module is no longer "supported" to work on PE/PC? I would prefer to say that we "can no longer verify functionality on PE/PC" and that additional testing is required.
It sound less harsh and might motivate people to move from PE/PC to OpenVox. If we just say "no support", people might not doing updates anymore or build something by themselves.

To me, those two things are equivalent. I personally prefer the stronger language to make it very clear that if you run into a problem with this in PE/PC, there's probably not much we can do about it (guessing a solution without being able to test it is not a good strategy). I also think the stronger language would make people more likely to move to OpenVox in order to get support, but perhaps that's true. But I also take your point that it may lead to people sticking with an old version and never updating. If people would like the softer language, I can change it.

I agree with Tuxmea, rather write something like "We can no longer verify functionality on PE/PC for licensing reasons. Additional testing will/could be required".
This will encourage more people to test the module and - perhaps - report the result instead of leaving it. Especially companies with larger or more extensive infrastructures will only be able to switch to OpenVox in the long term, even if they want to.

@binford2k
Copy link
Member

I suppose we could even add a link.

Before using this module with Puppet Core, we suggest testing it yourself.

@tuxmea
Copy link
Member

tuxmea commented Jun 17, 2025

please use correct link: https://www.puppet.com/docs/pdk/latest/pdk_testing.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-feedback Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants