Add input to allow signing release commits #81
Conversation
h-haaks
force-pushed
the
allow-signing-commits
branch
from
b374891 to
9798ac6
Compare
| commit-message: "Release ${{ inputs.version }}" | ||
| branch: release-prep | ||
| delete-branch: true | ||
| sign-commits: ${{ inputs.sign-commits }} |
There was a problem hiding this comment.
Q: Given the github_pat secret is required, and passed to the token, can't we just hardcode this parameter to true?
There was a problem hiding this comment.
I'm not sure if a PAT works at all really, because there is no way store a private key on a regular user.
My thought was to keep this default false for now, and then we could try to replace secrets.PCCI_PAT_RELEASE_PREP with secrets.GITHUB_TOKEN in one of the voxpupuli module repo workflows.
There was a problem hiding this comment.
I have tested ( in my private repo workflow ) that this workflow can be used with app tokens. That's why I changed the decription of 'github_pat'.
|
Using app tokens in reusable workflows is not as straight forward as I thought ... |
h-haaks
force-pushed
the
allow-signing-commits
branch
3 times, most recently
from
8a41932 to
83da066
Compare
h-haaks
force-pushed
the
allow-signing-commits
branch
from
83da066 to
5cd8ae0
Compare
2 participants
I'm currently trying to use these workflows in our private github repos where we require commits to be signed.
This PR allow setting the 'sign-commits' input of peter-evans/create-pull-request.