Skip to content

Add typescript declaration file - #174

Open
ramijarrar wants to merge 1 commit into
voximplant:masterfrom
avorra:add-dts
Open

Add typescript declaration file#174
ramijarrar wants to merge 1 commit into
voximplant:masterfrom
avorra:add-dts

Conversation

@ramijarrar

@ramijarrar ramijarrar commented Dec 23, 2022

Copy link
Copy Markdown

This is an update of the original PR by @davidnum which is synced up to the latest version of the library (i.e. including call quality APIs).

I have double-checked all definitions against the Voximplant API reference/source code to correct any missing fields & incorrect types.

I also heavily reworked it to closely mirror the existing library code structure including ordering definitions, labeling equivalent event handlers, rearranging structures, etc.

This should hopefully make it easier to review and ensure compliance (if that was what held it up last time).

@nagyszili

Copy link
Copy Markdown

This would be a huge improvement

@ramijarrar

ramijarrar commented Jan 26, 2023

Copy link
Copy Markdown
Author

Updated for v1.36.0 (adds CameraManager.useOrientationEventListener).

@ramijarrar

Copy link
Copy Markdown
Author

Updated for v1.37.0 (types unaffected).

@ramijarrar

Copy link
Copy Markdown
Author

Updated for v1.40.1.

Also refactored event handler types to more closely mirror the library code.

@ramijarrar

Copy link
Copy Markdown
Author

Rebased for v1.40.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants