-
Notifications
You must be signed in to change notification settings - Fork 676
Release/v1.9.0 #6436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Release/v1.9.0 #6436
Changes from 196 commits
aa69e2c
de35816
cd9fc67
d16cf5b
ec3c8d6
d3ed142
ebef0c2
789635f
79148e2
d8790d8
c4ebf7a
e7765c1
5b56dc3
b186eed
f8dd8f5
7ef355d
bff1db5
0da319b
539af27
f2f926a
de914f0
affbdb7
1854c85
1a4bfbf
3733f55
686ef6e
a93d2c1
f5e02a7
3baba7d
7f9442b
f310361
7eb1552
b278206
2b8d060
cac50e6
1d3a4cf
1b8d3fa
e4598a0
bef096e
b112baf
fde36a5
c6920b6
e304c00
20dfcef
fb54cf1
520cb9e
15b3b74
5dd2ad5
404c103
450a96b
a51add4
6670c91
ab19243
f780f28
c738e26
4ad3cbb
1284f92
fb70d0d
567af77
12cf39a
9ee964e
f27d0a9
df28786
aff8fac
9c51027
09b80cc
0ceafcd
ad6b2f2
b8b7cb9
bb2bbc9
91de38d
34968cb
1823f5c
824ce04
2c90638
17fd1a7
13ef26f
10cdfb5
ef9ea1a
269b15f
78bdf85
c33ef79
7273637
b3e7520
2853b72
bc343f3
4bdc31f
53a3726
7a450fe
cbdf259
e185242
332b813
ca9a71c
23b6268
c3b1edd
30a246f
7f2b929
fea0bf1
9f53208
ad8b699
d069ad0
41f664c
6c90762
bf82f62
5618701
6b08c34
33a7e43
f8fe8de
651bf38
25e1f67
37ffd67
4bf0a5e
c337c4a
5400280
18e1a91
44e63c0
b565dec
4b0f971
ca9e1b2
2ea223c
acc8f95
0e440f8
ae7e3e4
77145b3
b840caa
e299b7b
67f8f74
3ca8ba0
7bd4d32
f94d36f
69bfaa2
1c8c2c6
cf14ac0
9773daa
72c4a60
590465c
258db57
65eb179
23b4ae2
68d5c74
ada5fd1
f0565d3
348671c
1aa4c2a
2b7c40f
2aa1e0a
1ff3c24
48ecd2a
368648d
f7cc808
93f5b95
feef26e
a57e299
00611d8
6cd4466
35e8e63
0b123fb
2f835d9
a3777d7
ac17383
b40750c
8a3f82d
cdc1174
0d86728
3172ea4
5872c4f
2a5567e
8b8b581
f03dc76
c930a93
98136ac
3f51cab
bb5fc3a
836de52
5ec9202
9223dc7
5d5c1db
e6a8456
ae304ba
af0f685
d45f483
01cd890
7a9dba3
bcc96b8
376becf
6fc3983
29a5cfc
c9dcfa4
a8651ef
8998db9
136a650
4c2dbb3
98a5241
eef150a
126520c
bc36a17
8f55565
4559f99
e716408
5a0096f
6653df7
0bc3e00
d8f8556
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,9 +24,9 @@ jobs: | |
- windows-x86_64 | ||
steps: | ||
- name: Clone fiftyone | ||
uses: actions/checkout@v4 | ||
uses: actions/checkout@v5 | ||
- name: Set up Python 3.9 | ||
uses: actions/setup-python@v5 | ||
uses: actions/setup-python@v6 | ||
with: | ||
python-version: 3.9 | ||
- name: Install dependencies | ||
|
@@ -84,14 +84,14 @@ jobs: | |
FIFTYONE_DO_NOT_TRACK: true | ||
steps: | ||
- name: Clone fiftyone | ||
uses: actions/checkout@v4 | ||
uses: actions/checkout@v5 | ||
- name: Download fiftyone-db | ||
uses: actions/download-artifact@v4 | ||
uses: actions/download-artifact@v5 | ||
with: | ||
name: dist-sdist | ||
path: downloads | ||
- name: Set up Python 3.9 | ||
uses: actions/setup-python@v5 | ||
uses: actions/setup-python@v6 | ||
with: | ||
python-version: 3.9 | ||
- name: Install fiftyone-db | ||
|
@@ -109,23 +109,21 @@ jobs: | |
runs-on: ubuntu-latest | ||
needs: [build, test] | ||
if: startsWith(github.ref, 'refs/tags/db-v') | ||
environment: release # For trusted publishing. See below. | ||
permissions: | ||
contents: read | ||
id-token: write | ||
steps: | ||
- name: Download | ||
uses: actions/download-artifact@v4 | ||
uses: actions/download-artifact@v5 | ||
with: | ||
path: downloads | ||
- name: Install dependencies | ||
run: | | ||
pip3 install -U twine packaging | ||
- name: Set environment | ||
env: | ||
RELEASE_TAG: ${{ github.ref }} | ||
run: | | ||
echo "TWINE_PASSWORD=${{ secrets.FIFTYONE_PYPI_TOKEN }}" >> $GITHUB_ENV | ||
echo "TWINE_REPOSITORY=pypi" >> $GITHUB_ENV | ||
- name: Upload to pypi | ||
env: | ||
TWINE_USERNAME: __token__ | ||
TWINE_NON_INTERACTIVE: 1 | ||
run: | | ||
python3 -m twine upload downloads/dist-*/* | ||
pattern: dist-* | ||
merge-multiple: true | ||
path: dist | ||
# Utilize | ||
# [trusted publishers](https://docs.pypi.org/trusted-publishers/) | ||
# This will use OIDC to publish the dists/ package to pypi. | ||
# See | ||
# [fiftyone-db](https://pypi.org/manage/project/fiftyone-db/settings/publishing/) | ||
- name: Publish | ||
uses: pypa/[email protected] |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,13 +46,13 @@ jobs: | |
steps: | ||
- name: Clone fiftyone for tag builds | ||
if: github.ref_type == 'tag' | ||
uses: actions/checkout@v4 | ||
uses: actions/checkout@v5 | ||
with: | ||
# Fetch full history for rev-parse to work | ||
fetch-depth: 0 | ||
- name: Clone fiftyone for branch builds | ||
if: github.ref_type == 'branch' | ||
uses: actions/checkout@v4 | ||
uses: actions/checkout@v5 | ||
- name: Get Branch Name | ||
id: get_branch | ||
run: | | ||
|
@@ -90,14 +90,14 @@ jobs: | |
esac | ||
fi | ||
- name: Checkout fiftyone-teams | ||
uses: actions/checkout@v4 | ||
uses: actions/checkout@v5 | ||
with: | ||
repository: voxel51/fiftyone-teams | ||
path: fiftyone-teams | ||
token: ${{ secrets.RO_FOT_FG_PAT }} | ||
ref: ${{ steps.get_branch.outputs.branch_name }} | ||
- name: Set up Python 3.11 | ||
uses: actions/setup-python@v5 | ||
uses: actions/setup-python@v6 | ||
with: | ||
python-version: "3.11" | ||
- name: Install pip dependencies | ||
|
@@ -157,16 +157,16 @@ jobs: | |
runs-on: ubuntu-latest | ||
steps: | ||
- name: Download docs | ||
uses: actions/download-artifact@v4 | ||
uses: actions/download-artifact@v5 | ||
with: | ||
name: docs | ||
path: docs-download/ | ||
- name: Authorize gcloud | ||
uses: google-github-actions/auth@v2 | ||
uses: google-github-actions/auth@v3 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion | 🟠 Major 🧩 Analysis chainVerify the google-github-actions/auth@v3 upgrade. Ensure v3 is stable and check for breaking changes in authentication setup. 🌐 Web query:
💡 Result: Latest stable: v3 (published as v3.0.0). [1][2] Breaking changes in v3: bump to Node 24 (runner must support Node 24+) and removal of some older parameters/flags (and removal of a legacy "hacky" script). These are the primary breaking items called out in the v3 release notes. [1][2] Sources: Ensure runner supports Node 24+ and remove deprecated flags for google-github-actions/auth@v3: v3.0.0 is the latest stable release; it bumps to Node 24 and removes older parameters/flags and a legacy script—update your runner environment to Node 24+ and remove or update any deprecated flags in .github/workflows/build-docs.yml. 🤖 Prompt for AI Agents
|
||
with: | ||
credentials_json: "${{ secrets.DOCS_GCP_CREDENTIALS }}" | ||
- name: Set up gcloud | ||
uses: google-github-actions/setup-gcloud@v2 | ||
uses: google-github-actions/setup-gcloud@v3 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chainVerify the google-github-actions/setup-gcloud@v3 upgrade. Confirm v3 compatibility and check for any breaking changes. 🌐 Web query:
💡 Result: Latest stable release: v3.0.1. [1] Breaking changes in v3:
Sources: GitHub releases and repo README. [1][2] Ensure Node 24+ runner and update caching for setup-gcloud v3
🤖 Prompt for AI Agents
|
||
- name: publish | ||
run: gsutil -m rsync -dR -x '^SBOMs/.*' docs-download gs://docs.voxel51.com | ||
|
||
|
@@ -178,15 +178,15 @@ jobs: | |
runs-on: ubuntu-latest | ||
steps: | ||
- name: Download docs | ||
uses: actions/download-artifact@v4 | ||
uses: actions/download-artifact@v5 | ||
with: | ||
name: docs | ||
path: docs-download/ | ||
- name: Authorize gcloud | ||
uses: google-github-actions/auth@v2 | ||
uses: google-github-actions/auth@v3 | ||
with: | ||
credentials_json: "${{ secrets.DOCS_GCP_CREDENTIALS }}" | ||
- name: Set up gcloud | ||
uses: google-github-actions/setup-gcloud@v2 | ||
uses: google-github-actions/setup-gcloud@v3 | ||
- name: publish | ||
run: gsutil -m rsync -dR -x '^robots.txt' docs-download gs://docs.dev.voxel51.com |
Original file line number | Diff line number | Diff line change | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -7,9 +7,9 @@ jobs: | |||||||||||||||
runs-on: ubuntu-latest | ||||||||||||||||
steps: | ||||||||||||||||
- name: Checkout repository | ||||||||||||||||
uses: actions/checkout@v4 | ||||||||||||||||
uses: actions/checkout@v5 | ||||||||||||||||
|
||||||||||||||||
- uses: actions/checkout@v4 | ||||||||||||||||
- uses: actions/checkout@v5 | ||||||||||||||||
Comment on lines
+10
to
+12
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove duplicate checkout step. Lines 10 and 12 both perform Apply this diff to remove the duplicate: - name: Checkout repository
uses: actions/checkout@v5
- - uses: actions/checkout@v5
- uses: dorny/paths-filter@v3 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents
|
||||||||||||||||
- uses: dorny/paths-filter@v3 | ||||||||||||||||
id: changes | ||||||||||||||||
with: | ||||||||||||||||
|
@@ -18,7 +18,7 @@ jobs: | |||||||||||||||
- 'app/**' | ||||||||||||||||
- name: Set up Node.js | ||||||||||||||||
uses: actions/setup-node@v4 | ||||||||||||||||
uses: actions/setup-node@v5 | ||||||||||||||||
with: | ||||||||||||||||
node-version: "22" | ||||||||||||||||
|
||||||||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,27 +19,23 @@ jobs: | |
publish: | ||
runs-on: ubuntu-latest | ||
needs: [build, test] | ||
environment: release # For trusted publishing. See below. | ||
permissions: | ||
contents: read | ||
id-token: write | ||
steps: | ||
- name: Download dist | ||
uses: actions/download-artifact@v4 | ||
uses: actions/download-artifact@v5 | ||
with: | ||
name: dist | ||
path: dist/ | ||
- name: Install dependencies | ||
run: | | ||
pip3 install -U twine packaging | ||
- name: Set environment | ||
env: | ||
RELEASE_TAG: ${{ github.ref }} | ||
run: | | ||
echo "TWINE_PASSWORD=${{ secrets.FIFTYONE_PYPI_TOKEN }}" >> $GITHUB_ENV | ||
echo "TWINE_REPOSITORY=pypi" >> $GITHUB_ENV | ||
- name: Upload to pypi | ||
env: | ||
TWINE_USERNAME: __token__ | ||
TWINE_NON_INTERACTIVE: 1 | ||
run: | | ||
python3 -m twine upload dist/* | ||
# Utilize | ||
# [trusted publishers](https://docs.pypi.org/trusted-publishers/) | ||
# This will use OIDC to publish the dists/ package to pypi. | ||
# See | ||
# [fiftyone](https://pypi.org/manage/project/fiftyone/settings/publishing) | ||
- name: Publish | ||
uses: pypa/[email protected] | ||
|
||
publish-docker-images: | ||
needs: [publish] | ||
|
@@ -53,7 +49,7 @@ jobs: | |
- "3.12" | ||
steps: | ||
- name: Clone fiftyone | ||
uses: actions/checkout@v4 | ||
uses: actions/checkout@v5 | ||
|
||
- name: Set Env Vars | ||
run: | | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,6 +27,6 @@ | |
"lodash": "^4.17.21", | ||
"prettier": "2.2.1", | ||
"typescript": "4.2.4", | ||
"vite": "^5.4.19" | ||
"vite": "^5.4.20" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
🧩 Analysis chain
Verify the actions/download-artifact@v5 upgrade.
Confirm v5 compatibility and check for any breaking changes.
🌐 Web query:
💡 Result:
Latest stable: v5.0.0 (release). [1][2]
Breaking changes in v5:
Sources: GitHub Releases for actions/download-artifact (v5.0.0) and changelog. [1][2]
Update download-artifact step to include artifact name in path for v5
actions/[email protected] removes the default artifact-name subfolder for single-ID downloads and extracts directly into the given path. If your workflow expects a nested directory, amend the path in .github/workflows/build-docs.yml:160 to include the artifact name explicitly.
🤖 Prompt for AI Agents