FOEPD-2119: Use SaveContext to write to DB in background thread

fiftyone/core/collections.py

@@ -234,6 +234,26 @@ def _save_batch(self):
             self._reload_parents.clear()
 
 
+class AsyncSaveContext(SaveContext):
+    def __init__(self, *args, executor=None, **kwargs):
+        if executor is None:
+            raise ValueError("executor must be specified")
+        super().__init__(*args, **kwargs)
+        self.executor = executor
+
+    def __enter__(self):
+        super().__enter__()
+        self.executor.__enter__()
+        return self
+
+    def __exit__(self, *args):
+        super().__exit__(*args)
+        self.executor.__exit__(*args)
+
+    def _save_batch(self):
+        self.executor.submit(super()._save_batch)
+
+
 class SampleCollection(object):
     """Abstract class representing an ordered collection of
     :class:`fiftyone.core.sample.Sample` instances in a

fiftyone/core/models.py

@@ -9,6 +9,7 @@
 import contextlib
 import inspect
 import logging
+from concurrent.futures import ThreadPoolExecutor
 
 import numpy as np
 
@@ -477,7 +478,11 @@ def _apply_image_model_data_loader(
 
     with contextlib.ExitStack() as context:
         pb = context.enter_context(fou.ProgressBar(samples, progress=progress))
-        ctx = context.enter_context(foc.SaveContext(samples))
+        ctx = context.enter_context(
+            foc.AsyncSaveContext(
+                samples, executor=ThreadPoolExecutor(max_workers=1)
+            )
+        )
 
         def save_batch(sample_batch, labels_batch):
             with _handle_batch_error(skip_failures, sample_batch):
@@ -1210,7 +1215,11 @@ def _compute_image_embeddings_data_loader(
     with contextlib.ExitStack() as context:
         pb = context.enter_context(fou.ProgressBar(samples, progress=progress))
         if embeddings_field is not None:
-            ctx = context.enter_context(foc.SaveContext(samples))
+            ctx = context.enter_context(
+                foc.AsyncSaveContext(
+                    samples, executor=ThreadPoolExecutor(max_workers=1)
+                )
+            )
         else:
             ctx = None