Add If-Match
header to sample patch endpoints
#9932
pr.yml
on: pull_request
modified-files
30s
teams
Matrix: test / test-python
build
/
changes
29s
build
/
build
3m 44s
e2e
/
test-e2e
16m 49s
lint
/
eslint
2m 17s
test
/
test-app
4m 44s
Matrix: test-windows / test-python
all-tests
2s
Annotations
3 errors, 27 warnings, and 1 notice
e2e / test-e2e:
e2e-pw/src/oss/specs/3d/fo3d-ply.spec.ts#L83
'page' is defined but never used
|
[chromium] › src/oss/specs/smoke-tests/embeddings.spec.ts:60:3 › embeddings on quickstart dataset › embeddings panel opens:
e2e-pw/src/oss/poms/panels/embeddings-panel.ts#L29
2) [chromium] › src/oss/specs/smoke-tests/embeddings.spec.ts:60:3 › embeddings on quickstart dataset › embeddings panel opens
TypeError: Cannot destructure property 'x' of '(intermediate value)' as it is null.
at oss/poms/panels/embeddings-panel.ts:29
27 |
28 | async selectAll() {
> 29 | const { x, y, width, height } = await this.plotContainer.boundingBox();
| ^
30 |
31 | const [x1, y1] = [x, y + 100];
32 | const [x2, y2] = [x + width, y + 100];
at EmbeddingsPom.selectAll (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/panels/embeddings-panel.ts:29:13)
at EmebddingsAsserter.verifyLassoSelectsSamples (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/panels/embeddings-panel.ts:68:5)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/smoke-tests/embeddings.spec.ts:69:5
|
[chromium] › src/oss/specs/sidebar/sidebar.spec.ts:211:3 › sidebar-filter-visibility › In grid:
e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts#L251
1) [chromium] › src/oss/specs/sidebar/sidebar.spec.ts:211:3 › sidebar-filter-visibility › In grid, omit samples with a label filter works
Error: expect(locator).toHaveScreenshot(expected)
5899 pixels (ratio 0.04 of all image pixels) are different.
Expected: /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts-snapshots/hide-bottle-show-horse-chromium-linux.png
Received: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-sidebar-sidebar--13e0e-s-with-a-label-filter-works-chromium/hide-bottle-show-horse-actual.png
Diff: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-sidebar-sidebar--13e0e-s-with-a-label-filter-works-chromium/hide-bottle-show-horse-diff.png
Call log:
- expect.toHaveScreenshot(hide-bottle-show-horse.png) with timeout 5000ms
- verifying given screenshot expectation
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_cc4o6_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- 5899 pixels (ratio 0.04 of all image pixels) are different.
- waiting 100ms before taking screenshot
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_cc4o6_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- captured a stable screenshot
- 5899 pixels (ratio 0.04 of all image pixels) are different.
249 | );
250 |
> 251 | await expect(await grid.getForwardSection()).toHaveScreenshot(
| ^
252 | "hide-bottle-show-horse.png",
253 | { animations: "allow" }
254 | );
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts:251:50
|
lint / eslint:
app/packages/operators/src/built-in-operators.ts#L40
'Clear' is defined but never used. Allowed unused vars must match /^_|React/u
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L116
React Hook useEffect has a missing dependency: 'dimensions'. Either include it or remove the dependency array
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L52
React Hook useEffect has missing dependencies: 'panelId', 'panelName', 'props.onUnLoad', 'setPanelCloseEffect', 'trackEvent', and 'triggerPanelEvent'. Either include them or remove the dependency array
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L40
'pending' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L38
'data' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L37
'panelSchema' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L36
'handlePanelStatePathChange' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L35
'handlePanelStateChange' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L28
'panelLabel' is assigned a value but never used. Allowed unused vars must match /^_|React/u
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L1
'CodeBlock' is defined but never used. Allowed unused vars must match /^_|React/u
|
test / test-python (ubuntu-latest-m, 3.9)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test / test-python (ubuntu-latest-m, 3.11)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test / test-python (ubuntu-latest-m, 3.12)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test / test-python (ubuntu-latest-m, 3.10)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
e2e / test-e2e
Unexpected input(s) 'working-directory', valid inputs are ['path', 'key', 'restore-keys', 'upload-chunk-size', 'enableCrossOsArchive', 'fail-on-cache-miss', 'lookup-only', 'save-always']
|
e2e / test-e2e:
e2e-pw/src/oss/specs/regression-tests/media-field.spec.ts#L85
Unexpected use of the `.skip()` annotation
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/smoke-tests/quickstart.spec.ts#L0
e2e-pw/[chromium] › src/oss/specs/smoke-tests/quickstart.spec.ts took 29.2s
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts#L0
e2e-pw/[chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts took 37.9s
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/groups/sparse-groups.spec.ts#L0
e2e-pw/[chromium] › src/oss/specs/groups/sparse-groups.spec.ts took 41.4s
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/smoke-tests/quickstart-groups.spec.ts#L0
e2e-pw/[chromium] › src/oss/specs/smoke-tests/quickstart-groups.spec.ts took 48.1s
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/smoke-tests/field-visibility.spec.ts#L0
e2e-pw/[chromium] › src/oss/specs/smoke-tests/field-visibility.spec.ts took 55.4s
|
e2e / test-e2e
Unexpected input(s) 'working-directory', valid inputs are ['path', 'key', 'restore-keys', 'upload-chunk-size', 'enableCrossOsArchive', 'fail-on-cache-miss', 'lookup-only', 'save-always']
|
e2e / test-e2e
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test-windows / test-python (windows-latest, 3.10)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test-windows / test-python (windows-latest, 3.9)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test-windows / test-python (windows-latest, 3.12)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test-windows / test-python (windows-latest, 3.11)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
🎭 Playwright Run Summary
2 flaky
[chromium] › src/oss/specs/sidebar/sidebar.spec.ts:211:3 › sidebar-filter-visibility › In grid, omit samples with a label filter works
[chromium] › src/oss/specs/smoke-tests/embeddings.spec.ts:60:3 › embeddings on quickstart dataset › embeddings panel opens
2 skipped
96 passed (9.1m)
|
Artifacts
Produced during runtime
Name | Size | Digest | |
---|---|---|---|
dist
|
20.7 MB |
sha256:906ed2439264b1712f950bfeab5c51112eb41ad430a72dc86c19ea6e8f5dedd1
|
|
playwright-report
|
26.7 MB |
sha256:92d16b7673c0f134a2af94bab4264b64092f2902c98e8f8f10976a0c4f4668ca
|
|