Skip to content

Conversation

@kluge7
Copy link
Contributor

@kluge7 kluge7 commented Oct 26, 2025

No description provided.

@kluge7 kluge7 linked an issue Oct 26, 2025 that may be closed by this pull request
9 tasks
@kluge7 kluge7 requested a review from Copilot October 26, 2025 18:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds training scripts and configurations for running YOLO and U-Net models on the Idun cluster, while restructuring the project to support multiple model training workflows.

Key Changes:

  • Added new training directories with scripts for YOLO and U-Net models
  • Created SLURM job configurations for GPU-based training on the Idun cluster
  • Updated CI/CD workflows to reference the new requirements.txt location

Reviewed Changes

Copilot reviewed 11 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
yolo_roboflow_training/train.py Training script for YOLO model using Roboflow datasets
yolo_roboflow_training/requirements.txt Python dependencies for YOLO training
yolo_roboflow_training/Job.slurm SLURM configuration for YOLO training jobs
unet_roboflow_training/train.py Training script for U-Net segmentation model
unet_roboflow_training/test.py Inference script for testing trained U-Net models
unet_roboflow_training/requirements.txt Python dependencies for U-Net training
unet_roboflow_training/Job.slurm SLURM configuration for U-Net training jobs
YOLO-detect-buoys/requirements.txt Moved requirements file to project directory
YOLO-detect-buoys/main.py Updated to use Unix-style paths and added model export
YOLO-detect-buoys/Job.slurm SLURM configuration for buoy detection training
.github/workflows/pylint.yml Updated to reference new requirements.txt location
Comments suppressed due to low confidence (2)

YOLO-detect-buoys/Job.slurm:1

  • Invalid SLURM time format '999:99:99'. The time format should be DD-HH:MM:SS, HH:MM:SS, or MM:SS with valid values (e.g., hours 0-23, minutes/seconds 0-59).
    YOLO-detect-buoys/Job.slurm:1
  • The script references 'train.py' but the main entry point in this directory is 'main.py'. This should be 'python3 main.py' or 'python3 -m YOLO-detect-buoys'.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# Step 1: Download Dataset from Roboflow
ROBOFLOW_API_KEY = "" # Replace with your Roboflow API Key
PROJECT_NAME = "" # Replace with your project id
VERSION = "" # Replace with your dataset version number exluding the 'v'
Copy link

Copilot AI Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'exluding' to 'excluding'.

Suggested change
VERSION = "" # Replace with your dataset version number exluding the 'v'
VERSION = "" # Replace with your dataset version number excluding the 'v'

Copilot uses AI. Check for mistakes.
# export PYTORCH_CUDA_ALLOC_CONF="expandable_segments:True,max_split_size_mb:128"
export PYTORCH_CUDA_ALLOC_CONF="expandable_segments:True"

python3 train.py
Copy link

Copilot AI Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SLURM script attempts to run 'train.py' but is located in YOLO-detect-buoys directory. Based on the file location (yolo_roboflow_training/Job.slurm), this should execute the training script in the current directory or specify the correct path.

Suggested change
python3 train.py
python3 ../YOLO-detect-buoys/train.py

Copilot uses AI. Check for mistakes.
#!/bin/bash
#SBATCH --partition=GPUQ
#SBATCH --account=ie-idi
#SBATCH --time=999:99:99
Copy link

Copilot AI Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid SLURM time format '999:99:99'. The time format should be DD-HH:MM:SS, HH:MM:SS, or MM:SS with valid values (e.g., hours 0-23, minutes/seconds 0-59).

Suggested change
#SBATCH --time=999:99:99
#SBATCH --time=7-00:00:00

Copilot uses AI. Check for mistakes.
from roboflow import Roboflow

# Step 1: Download Dataset from Roboflow
ROBOFLOW_API_KEY = "" # Replace with your Roboflow API Key
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad practice. Should instead be loaded from another file which must be added to .gitignore (for example a .env file). This is done to avoid accidentally committing API keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Start the traning on idun

5 participants