chore: format and remove dead code from SidebarChat.tsx #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdawger
commented
Jun 26, 2025
|
|
||
|
|
||
| export const IconX = ({ size, className = '', ...props }: { size: number, className?: string } & React.SVGProps<SVGSVGElement>) => { | ||
| import React, { |
There was a problem hiding this comment.
Best to view this NOT in diff view as you'll see the improvement.
vdawger
commented
Jun 26, 2025
| return ( | ||
| <svg | ||
| xmlns='http://www.w3.org/2000/svg' | ||
| xmlns="http://www.w3.org/2000/svg" |
There was a problem hiding this comment.
Prettier is opinionated about ' vs ". This is less of a noticeable improvement than the other formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
SidebarChat.tsxis a lot more readable now.It had a lot of unused imports, some unused functions, and some unused component parameters.
Before:
After (no unused imports and more readable):
Changes
organize importsto remove unused imports and alphabetize used ones.iconproperty fromToolHeaderWrapperas it was unused.iconfield from all calls toToolHeaderWrapper.SimplifiedToolHeadercomponent as it is not used anywhere.Testing
It builds and runs.
No functional code was modified.