Skip to content

prevent blank windows #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

prevent blank windows #769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions src/vs/platform/windows/electron-main/windowImpl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,9 +256,8 @@ export abstract class BaseWindow extends Disposable implements IBaseWindow {
this.setFullScreen(true, true);
}

// to reduce flicker from the default window size
// to maximize or fullscreen, we only show after
this._win?.show();
// Don't show the window here anymore - it will be shown by ready-to-show event
// this prevents blank windows on macOS
}
}

Expand Down Expand Up @@ -594,7 +593,22 @@ export class CodeWindow extends BaseWindow implements ICodeWindow {
this._id = this._win.id;
this.setWin(this._win, options);

// Apply some state after window creation
// Handle ready-to-show event to prevent blank windows on macOS
this._register(Event.fromNodeEventEmitter(this._win, 'ready-to-show')(() => {
if (this._win && !this._win.isDestroyed()) {
// Show the window once content is ready
this._win.show();

// Apply maximized/fullscreen state after showing if needed
if (this.windowState.mode === WindowMode.Maximized) {
this._win.maximize();
} else if (this.windowState.mode === WindowMode.Fullscreen) {
this.setFullScreen(true, true);
}
}
}));

// Apply some state after window creation (but don't show yet)
this.applyState(this.windowState, hasMultipleDisplays);

this._lastFocusTime = Date.now(); // since we show directly, we need to set the last focus time too
Expand Down
2 changes: 1 addition & 1 deletion src/vs/platform/windows/electron-main/windows.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export function defaultBrowserWindowOptions(accessor: ServicesAccessor, windowSt
minWidth: WindowMinimumSize.WIDTH,
minHeight: WindowMinimumSize.HEIGHT,
title: productService.nameLong,
show: windowState.mode !== WindowMode.Maximized && windowState.mode !== WindowMode.Fullscreen, // reduce flicker by showing later
show: false, // Always start hidden to prevent blank windows, will be shown via ready-to-show event
x: windowState.x,
y: windowState.y,
width: windowState.width,
Expand Down