rust: Enable Rust builtin_profiler#32362
Closed
s34m wants to merge 2 commits intovoid-linux:masterfrom
Closed
Conversation
ericonr
reviewed
Aug 6, 2021
Member
ericonr
left a comment
There was a problem hiding this comment.
Please fix the commit message, the title is too long.
Member
|
You only fixed the PR title, not the commit itself. |
Member
|
Per rust-lang/rust#79121, this is still an unstable feature, and I don't think we should enable it in our distro toolchain. You probably want to use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ithout it
General
Have the results of the proposed changes been tested?
Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
[ci skip]