Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: massage protojson's output to use hex rather than base64 #1393

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

mvdan
Copy link
Contributor

@mvdan mvdan commented Sep 16, 2024

(see commit message)

Fixes #1354.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10892773448

Details

  • 22 of 26 (84.62%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.001%) to 62.302%

Changes Missing Coverage Covered Lines Changed/Added Lines %
api/helpers.go 22 26 84.62%
Files with Coverage Reduction New Missed Lines %
vochain/indexer/indexer.go 2 76.36%
vochain/state/account.go 2 67.46%
vochain/transaction/admin_tx.go 2 51.19%
vochain/transaction/election_tx.go 2 62.13%
Totals Coverage Status
Change from base Build 10791417569: -0.001%
Covered Lines: 16824
Relevant Lines: 27004

💛 - Coveralls

Copy link
Contributor

@altergui altergui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested, works flawlessly

@altergui altergui merged commit 8f73b2a into vocdoni:main Sep 17, 2024
11 checks passed
@mvdan mvdan deleted the api-proto-json-hex branch September 17, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: transaction information comes base64 encoded
3 participants