Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add endpoint for calculating the next electionId of an organization #1204

Merged
merged 2 commits into from
Nov 28, 2023
Merged

add endpoint for calculating the next electionId of an organization #1204

merged 2 commits into from
Nov 28, 2023

Conversation

jordipainan
Copy link
Member

@jordipainan jordipainan commented Nov 27, 2023 •
edited
Loading

closes #1203

@jordipainan jordipainan requested a review from p4u November 27, 2023 16:47
@coveralls
Copy link

coveralls commented Nov 27, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7017040909

  • 32 of 70 (45.71%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 61.662%
Changes Missing Coverage Covered Lines Changed/Added Lines %
api/elections.go 32 40 80.0%
apiclient/election.go 0 30 0.0%
Totals Coverage Status
Change from base Build 6983696410: 0.007%
Covered Lines: 14696
Relevant Lines: 23833
💛 - Coveralls

@jordipainan
Copy link
Member Author

@p4u solved encoding, ready to review

p4u
p4u approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@p4u p4u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please open the interoperability issue with an example of Body and response.

@jordipainan jordipainan merged commit 244ed50 into main Nov 28, 2023
11 checks passed
@jordipainan jordipainan deleted the f/1203 branch November 28, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p4u p4u p4u approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API: Return the next election ID
3 participants
@jordipainan @coveralls @p4u