stashed WalkDir cleanup, update pebble #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filepath.Walk is mainly useful for many levels of directories, but the archive data directory is entirely flat. Plus, filepath.Walk stats every file that it walks over. This is a bit simpler to understand and also less indented.
Note that pebble is making multiple breaking changes these days, and both us and go-ethereum use pebble, so we need to carefully update both dependencies together.
Pull Request Test Coverage Report for Build 6739006243
💛 - Coveralls |
|
Is this backwards compatible with previous pebble databases? |
|
I haven't checked. They are v0 and don't do releases, so they don't specify. The commits are just over 200: cockroachdb/pebble@06034ff...aa077af FormatDefault in that diff hasn't changed, meaning the DB format should still be the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit messages - please do not squash)