F/censusdb race #1175
Merged
F/censusdb race #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added a new global lock for censusDB. Before, the lock only affected the individual trees, however as censusDB is able to load the same tree twice (in case of paralel calls to the API census endpoints), a write operation could be done racy to the same tree database. Now Censusdb requires to call Unload() after Load() to release the lock. In addition, extend the import/export methods to allow IPFS transfers. Signed-off-by: p4u <[email protected]>
Pull Request Test Coverage Report for Build 6708329548
💛 - Coveralls |
Signed-off-by: p4u <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit message
@lucasmenendez if you are using censusdb, once you upgrade to the code containing this PR, you should call censusdb.Unload() after every Load() to release the lock.