indexer: static vote_count plus fixes #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While reading the code, I remembered that we store big integers in sqlite in quoted strings, for the sake of consistent JSON encoding. We weren't quoting in the fallback case if vote.Weight is nil, which could lead to decoding errors if we use that value.
Otherwise the map just keeps increasing in size forever, meaning that we do more and more busy work over time. It's surprising that we hadn't caught this bug for a long time. While here, initialize and clear both "by process ID" maps consistently.
We used to do this a while back, and replaced it with a COUNT plus JOIN with sqlite since the data was all in sqlite. However, we're now adding processes where the votes are not indexed, and we want to specify what the vote count is as a static integer. Make indexertypes.Process.VoteCount visible in JSON as well now, since it's a proper column and no longer derived data via COUNT. Updates vocdoni#1170.
Pull Request Test Coverage Report for Build 6699456848
💛 - Coveralls |
p4u
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit messages - please do not squash)
Updates #1170.