Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/integrated archive #1172

Merged
merged 2 commits into from
Nov 2, 2023
Merged

F/integrated archive #1172

merged 2 commits into from
Nov 2, 2023

Conversation

p4u
Copy link
Member

@p4u p4u commented Oct 30, 2023

Closes #1155

@p4u p4u requested a review from mvdan October 30, 2023 12:20
@p4u
Copy link
Member Author

p4u commented Oct 30, 2023

needs #1170 to finish

@p4u p4u force-pushed the f/integrated_archive branch from 7b0d3fb to 8fd060b Compare November 2, 2023 09:16
@p4u
Copy link
Member Author

p4u commented Nov 2, 2023

I'll merge this PR with as a partial solution. We still need to add some extra fields to indexer in order to make it fully transparent for the UI.

@coveralls
Copy link

coveralls commented Nov 2, 2023

Pull Request Test Coverage Report for Build 6731722824

  • 109 of 144 (75.69%) changed or added relevant lines in 6 files are covered.
  • 17 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.07%) to 61.53%

Changes Missing Coverage Covered Lines Changed/Added Lines %
vochain/processarchive/processarchive.go 0 1 0.0%
cmd/node/main.go 4 6 66.67%
data/datamocktest.go 3 5 60.0%
data/ipfs/ipfs.go 30 43 69.77%
vochain/indexer/archive.go 67 84 79.76%
Files with Coverage Reduction New Missed Lines %
api/accounts.go 2 47.39%
apiclient/account.go 2 40.92%
vochain/state/cache.go 2 61.54%
cmd/end2endtest/account.go 3 68.72%
data/datamocktest.go 4 49.23%
data/ipfs/ipfs.go 4 53.95%
Totals Coverage Status
Change from base Build 6731107320: 0.07%
Covered Lines: 14278
Relevant Lines: 23205

💛 - Coveralls

data/ipfs/ipfs.go Outdated Show resolved Hide resolved
vochain/indexer/archive.go Outdated Show resolved Hide resolved
vochain/indexer/archive.go Show resolved Hide resolved
@p4u p4u force-pushed the f/integrated_archive branch from 8fd060b to c7f103d Compare November 2, 2023 11:08
@p4u p4u merged commit 8b25d62 into main Nov 2, 2023
11 checks passed
@p4u p4u deleted the f/integrated_archive branch November 2, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate process archive in the API backend
3 participants