Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f/validator metrics #1171

Merged
merged 2 commits into from
Nov 6, 2023
Merged

f/validator metrics #1171

merged 2 commits into from
Nov 6, 2023

Conversation

altergui
Copy link
Contributor

  • state: move Validator methods into validators.go
  • state: add vochain_validator metric using NewGaugeVec

@altergui altergui linked an issue Oct 30, 2023 that may be closed by this pull request
validator metrics #1157
Closed
@altergui altergui force-pushed the f/validator-metrics branch from 0ad125c to 222a057 Compare October 30, 2023 14:51
@coveralls
Copy link

coveralls commented Oct 30, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6771211941

  • 36 of 77 (46.75%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 61.501%
Changes Missing Coverage Covered Lines Changed/Added Lines %
vochain/ist/validators.go 0 1 0.0%
vocone/vocone.go 0 1 0.0%
vochain/state/validators.go 36 75 48.0%
Totals Coverage Status
Change from base Build 6731987148: -0.01%
Covered Lines: 14286
Relevant Lines: 23229
💛 - Coveralls

@altergui altergui force-pushed the f/validator-metrics branch 3 times, most recently from b95a063 to 2fec58b Compare October 31, 2023 15:37
@altergui altergui self-assigned this Nov 6, 2023
@altergui altergui force-pushed the f/validator-metrics branch from 2fec58b to 5fa2ab4 Compare November 6, 2023 11:27
@altergui altergui marked this pull request as ready for review November 6, 2023 11:28
@altergui altergui requested a review from p4u November 6, 2023 11:44
@altergui altergui force-pushed the f/validator-metrics branch from 5fa2ab4 to 3a57367 Compare November 6, 2023 13:10
@altergui altergui merged commit fc0ffb8 into main Nov 6, 2023
11 checks passed
@altergui altergui deleted the f/validator-metrics branch November 6, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p4u p4u p4u approved these changes

Assignees

@altergui altergui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

validator metrics
3 participants
@altergui @coveralls @p4u