Skip to content

Commit

Permalink
testsuite: don't leak orphan networks in ci server
Browse files Browse the repository at this point in the history
until now, on every run a network testsuite_${{ github.run_id }}_default
was created, and not properly cleaned up (left behind in server)
after about 30 runs, CI on that server fails with
  Error response from daemon: could not find an available,
  non-overlapping IPv4 address pool among the defaults to assign to the network
until a `docker network prune` is run

while at it, don't expose grafana outside localhost
  • Loading branch information
altergui committed Oct 25, 2023
1 parent bf96064 commit da422da
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions dockerfiles/testsuite/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ services:
- gocoverage-miner3:/app/run/gocoverage/miner3
- gocoverage-gateway0:/app/run/gocoverage/gateway0
- gocoverage-test:/app/run/gocoverage/test
profiles:
- tools # this container is only intended to be `docker compose run`, no need to start on `docker compose up`
networks:
- blockchain

prometheus:
image: prom/prometheus:v2.26.0
Expand All @@ -144,7 +144,7 @@ services:
networks:
- blockchain
ports:
- 3000:3000
- "[::1]:3000:3000"
volumes:
- grafana_data:/var/lib/grafana
- ./grafana/provisioning/:/etc/grafana/provisioning/
Expand Down

0 comments on commit da422da

Please sign in to comment.