Skip to content

fix: gate tools by architecture#32

Merged
vnedyalk0v merged 1 commit into
devfrom
fix/gate-tool-architecture
Jun 5, 2026
Merged

fix: gate tools by architecture#32
vnedyalk0v merged 1 commit into
devfrom
fix/gate-tool-architecture

Conversation

@vnedyalk0v

Copy link
Copy Markdown
Owner

Summary

  • Add catalog architecture metadata and platform validation before dry-run/config emission.
  • Mark ChatGPT Desktop as macOS 14+ and arm64-only, matching Homebrew cask metadata.

Checklist

  • Base branch is dev (only dev or hotfix/* may target main).
  • Branch name uses a repo prefix (feat/, fix/, bug/, docs/, chore/, ci/, or refactor/) unless this is the main -> dev sync.
  • PR title starts with feat:, fix:, bug:, docs:, chore:, ci:, or refactor:.
  • The change matches docs/rig-v1-spec.md or updates the spec.
  • User-facing behavior is documented.
  • Security-sensitive behavior is documented or called out.
  • Dry-run behavior remains side-effect free.
  • Shell code that runs on a clean Mac is Bash 3.2-compatible.
  • Shell/config edits are idempotent.

Validation

for f in install.sh rig lib/rig/*.sh scripts/*.sh tests/*.sh; do bash -n "$f"; done
bash tests/run-tests.sh
./scripts/validate-catalog.sh
./rig install --dry-run --select vscode,chrome,node-npm --defaults finder-show-hidden-files
./install.sh --dry-run
shellcheck install.sh rig lib/rig/*.sh scripts/*.sh tests/*.sh
actionlint .github/workflows/*.yml
git diff --check

Security Impact

Catalog validation now rejects unsupported machine architecture tags and selected tools with unmet architecture requirements before rendering dry-run output or writing config. No installer execution, shell configuration, generated defaults, or update behavior changes.

@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@vnedyalk0v, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 33 minutes and 43 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7df132bb-0e94-4eb6-acf8-eaadb60192eb

📥 Commits

Reviewing files that changed from the base of the PR and between a14fdbb and bc91c16.

⛔ Files ignored due to path filters (1)
  • catalog/tools.tsv is excluded by !**/*.tsv
📒 Files selected for processing (6)
  • docs/rig-v1-spec.md
  • lib/rig/catalog.sh
  • lib/rig/common.sh
  • lib/rig/plan.sh
  • lib/rig/prompts.sh
  • tests/run-tests.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/gate-tool-architecture

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vnedyalk0v vnedyalk0v merged commit 71b0d51 into dev Jun 5, 2026
3 checks passed
@vnedyalk0v vnedyalk0v deleted the fix/gate-tool-architecture branch June 5, 2026 09:51

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bc91c162cb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/rig/common.sh
printf '%s\n' "$RIG_MACHINE_ARCH"
return 0
fi
uname -m 2>/dev/null

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Detect hardware arch instead of translated process arch

On Apple Silicon Macs where rig is launched from a terminal or automation running under Rosetta, uname -m reports the translated process architecture as x86_64, so selecting an arm64-only catalog entry such as chatgpt-desktop is rejected before dry-run/config emission even though the machine hardware is supported. Use a macOS hardware capability check or Rosetta-aware normalization here rather than the current process architecture.

Useful? React with 👍 / 👎.

vnedyalk0v added a commit that referenced this pull request Jun 5, 2026
* feat: expand tool catalog

* feat: add catalog entries with macOS gating

* fix: gate tools by architecture (#32)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant