Improved healt.sh, added health.ps, added instruction for use under win #922
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| $ErrorActionPreference= 'silentlycontinue' | ||
|
|
||
| [regex]$regex = "\d+\.\d+\.*\d*" | ||
| $yes = "`u{2714} " | ||
| $no = "`u{274c}" | ||
|
|
||
| $allChecks = $true | ||
|
|
||
| Write-Host "Starting Build Tools for VMware Aria Checks..." | ||
|
|
||
| # version should be at lest <major.minor> | ||
| # OpenSSL is not following the guidelines | ||
| @( | ||
| @{ name = "Java"; cmd="java --version"; min="17.0"; max="24.0" }, | ||
| @{ name = "Maven"; cmd="mvn --version"; min="3.2"; max="4.0" }, | ||
| @{ name = "Node.js"; cmd="node --version"; min="12.0"; max="24.0" }, | ||
|
Collaborator
There was a problem hiding this comment. For node currently the officially supported version is 22. Some lower versions might work in specific use cases but it is situational so that cannot be officially supported. |
||
| @{ name = "Python"; cmd="python --version"; min="3.2"; max="3.14" }, | ||
|
Collaborator
There was a problem hiding this comment. Python and pip are not required by default. Have in mind that the prereqs are not for building BTVA project itself but for building the projects generated by it's archetypes, e.g. vro js, vro ts, vra-ng, etc. So based on that I need to check with the team on how we want to handle this - throwing an error for missing python dependency on a regular JS based project would be misleading. maybe we can add a warning message for python and powershell that they might be required for polyglot project types. |
||
| @{ name = "Pip"; cmd="pip --version"; min="25.0"; max="26.0" }, | ||
| @{ name = "OpenSSL"; cmd="openssl version"; min="10.0"; max="17.0" } | ||
|
Collaborator
There was a problem hiding this comment. I think openssl shouldn't be required. If you encountered it in the instructions for generating an certificates for signing the Orchestrator packages this is meant to be just an example on how you can generate it. The prereq is having that certificate for signing packages and is only for Orchestrator projects but they can be generated in other ways including from external system and may also not be present on the system that is building the project but can be located in an artifactory. |
||
| ) | ForEach-Object { | ||
| $name = $_.name | ||
| $command = $_.cmd | ||
| $min = [Version]::Parse($_.min) | ||
| $max = [Version]::Parse($_.max) | ||
|
|
||
| $result = (Invoke-Expression $command) | ||
| if ($result -eq $null) | ||
| { | ||
| Write-Host "$no $name is not installed" -ForegroundColor Red | ||
| $allChecks = $false | ||
| return | ||
| } | ||
|
|
||
| $versionString = $result.Split([Environment]::NewLine)[0] | ||
| $version = [Version]::Parse($regex.Matches($versionString)[0].Value) | ||
|
|
||
| if ($version.CompareTo($min) -ge 0 -and $version.CompareTo($max) -le 0) | ||
| { | ||
| Write-Host "$yes $name version '$version' is within the required range ($min - $max)." -ForegroundColor Green | ||
| } else { | ||
| $allChecks=$false | ||
| Write-Host "$no $name version '$version' is outside of the range ($min - $max)." -ForegroundColor Red | ||
| } | ||
| $result = $null | ||
| } | ||
|
|
||
| if ( $all_checks_passed ) { | ||
| Write-Host "All checks passed successfully." -ForegroundColor Green | ||
| } else { | ||
| Write-Host "Some checks failed. Please review the above messages." -ForegroundColor Red | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,83 +1,67 @@ | ||
| GREEN="\033[0;32m" | ||
| RED="\033[0;31m" | ||
| NC="\033[0m" | ||
|
|
||
| all_checks_passed=true | ||
| regex="[[:digit:]]+\.[[:digit:]]+\.[[:digit:]]+" | ||
|
|
||
| # OpenSSL is not following the guidelines | ||
| declare -a prerequisites=( | ||
| "Java java --version 17 24" | ||
| "Maven mvn --version 3.2" | ||
| "Node.js nodejs --version 12 24" | ||
| "Python python --version 3.2 3.14" | ||
| "Pip pip --version 25.0 26.0" | ||
| "OpenSSL openssl version 10 17.0" | ||
| ) | ||
|
|
||
| v_compare() { | ||
| # Returns 0 if $1 >= $2, 1 otherwise | ||
| printf '%s\n%s\n' "$2" "$1" | sort -C -V | ||
| } | ||
|
|
||
| echo "Starting Build Tools for VMware Aria Checks..." | ||
|
|
||
| for prerequisite in "${prerequisites[@]}"; do | ||
| # uses default whitespace IFS | ||
| read -a properties <<< "$prerequisite" | ||
|
|
||
| name=${properties[0]} | ||
| command=${properties[1]} | ||
| action=${properties[2]} | ||
| min=${properties[3]} | ||
| max=${properties[4]:-default} | ||
|
|
||
| # first line is containing version | ||
| actual=$($command $action 2>/dev/null | head -n 1) | ||
|
|
||
| if [[ $actual =~ $regex ]]; then | ||
| actualVersion=${BASH_REMATCH[0]} | ||
| is_min_ok=false | ||
| is_max_ok=false | ||
|
|
||
| if v_compare "$actualVersion" "$min"; then | ||
| is_min_ok=true | ||
| fi | ||
|
|
||
| if v_compare "$max" "$actualVersion"; then | ||
| is_max_ok=true | ||
| fi | ||
|
|
||
| if $is_min_ok && $is_max_ok; then | ||
| echo -e "${GREEN}✔ ${name} version '${actualVersion}' is within the required range (${min} - ${max}).${NC}" | ||
| else | ||
| all_checks_passed=false | ||
| echo -e "${RED}✘ ${name} version '${actualVersion}' is outside of the range (${min} - ${max}).${NC}" | ||
| fi | ||
| else | ||
| echo -e "${RED}✘ ${name} is not installed.${NC}" | ||
| all_checks_passed=false | ||
| fi | ||
| done | ||
|
|
||
| if [ "$all_checks_passed" = true ]; then | ||
| echo -e "${GREEN}All checks passed successfully.${NC}" | ||
| else | ||
| echo -e "${RED}Some checks failed. Please review the above messages.${NC}" | ||
| fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For maven it is a bit hard to say since maven seems to be more flexible, I've tested with 3.6 - 3.9. but don't know about other versions.