This repository was archived by the owner on Nov 9, 2020. It is now read-only.
Handle case where device.backing.uuid is None #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the devices attached to VMs in my vsphere deployment apparently lack a backing uuid (ie.
device.backing.uuid is None). This ended up being an issue because this driver checks every VM to see if the device it needs is already attached elsewhere.During this process an
AttributeErrorwas being raised in_list_vsphere_volumeson line 586, specifically where_normalize_uuidwas called. This method presumes uuid is a string (and thus has .translate & .lower methods).This issue manifested itself in
vsphere.logwith the following error:Also rm'ed an unused import