Skip to content
This repository was archived by the owner on Nov 16, 2020. It is now read-only.

Update Knative version Readme #708

Open
wants to merge 4 commits into
base: knative
Choose a base branch
from
Open

Update Knative version Readme #708

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab92f84
Update Knative version Readme
pzmrzy Oct 31, 2018
f10e4c6
Fix jq format, Add note to dockerhub username
pzmrzy Oct 31, 2018
7cb41d2
Add optional step for tiller
pzmrzy Oct 31, 2018
e63e448
Add cluster zone env var
pzmrzy Nov 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ The diagram below illustrates the different components which make up the Dispatc

2. Create GKE cluster:
```bash
K8S_VERSION=1.10.7-gke.6
export K8S_VERSION=1.10.7-gke.6
export CLUSTER_NAME=dispatch-knative
gcloud container clusters create -m n1-standard-4 --cluster-version ${K8S_VERSION} ${CLUSTER_NAME}
gcloud container clusters get-credentials ${CLUSTER_NAME}
gcloud container clusters create -m n1-standard-4 --cluster-version ${K8S_VERSION} ${CLUSTER_NAME} --zone us-west1-c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make the zone an env var too?

gcloud container clusters get-credentials ${CLUSTER_NAME} --zone us-west1-c
```

3. Install Knative:
Expand All @@ -69,13 +69,15 @@ Installing Dispatch depends on having a Kubernetes cluster with the Knative comp
export RELEASE_NAME="dispatch-server"
export MINIO_USERNAME="dispatch"
export MINIO_PASSWORD="dispatch"
export INGRESS_IP=$(kubectl get service -n istio-system knative-ingressgateway -o json | jq -r .status.loadBalancer.ingress[].ip)
export DOCKER_REPOSITORY="{dockerhub_username}"
export INGRESS_IP=$(kubectl get service -n istio-system knative-ingressgateway -o json | jq -r ".status.loadBalancer.ingress[0].ip")
```

2. Build and publish a dispatch image:
```bash
PUSH_IMAGES=1 make images
```
> **NOTE**: You may need `docker login` before push
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit : You may need to docker login before push


3. The previous command will output a configuration file `values.yaml`:
```yaml
Expand All @@ -90,6 +92,10 @@ Installing Dispatch depends on having a Kubernetes cluster with the Knative comp

4. Deploy via helm chart (if helm is not installed and initialized, do that first):
```bash
cd charts/dispatch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to cd
helm dep up ./charts/dispatch/

helm dependency update
helm init
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably add a new optional step above for helm init and also mentions that tiller requires cluster admin privileges (refer the legacy installation steps)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: helm dep up instead of the verbose command

cd ../..
helm upgrade -i --debug ${RELEASE_NAME} ./charts/dispatch --namespace ${DISPATCH_NAMESPACE} -f values.yaml
```
> **NOTE**: Use following to create cluster role binding for tiller:
Expand Down Expand Up @@ -131,7 +137,7 @@ Installing Dispatch depends on having a Kubernetes cluster with the Knative comp
8. Test out your install:
First, create an baseimage:
```bash
dispatch create baseimage python3-base dispatchframework/python3-base:0.0.13-knative
dispatch create base-image python3-base dispatchframework/python3-base:0.0.13-knative
Created baseimage: python3-base
```
Then, create an image:
Expand Down Expand Up @@ -184,4 +190,8 @@ Installing Dispatch depends on having a Kubernetes cluster with the Knative comp
curl -v http://${INGRESS_IP}/hello?name=Jon -H 'Host: default.dispatch-server.dispatch.local'
```

9. Delete dispatch server
```bash
helm delete dispatch-server
```
For a more complete quickstart see the [developer documentation](#documentation)