Account for memory usage of other processes #18858
Open
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #18854
In
determine_available_memory
, the initial memory usage should be taken into account.Consider this script running on a 80GB A100:
If I print the memory metrics without my changes, the second process already crashes because the estimated available memory is negative:
Taking the initial memory into account, the 3 processes can run and the estimated memory is an exact match for the 3 processes: