-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
[LoRA] Add LoRA support for InternVL #18842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LoRA] Add LoRA support for InternVL #18842
Conversation
Signed-off-by: Jee Jee Li <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether we can have simple tests that apply randomly initialized LoRA adapter just to check that the LoRA adapters can be loaded into the model? (Can do this in another PR)
We only need to set |
We can add a test similar to |
Sound good, I will try adding this in the following PR |
packed_modules_mapping = { | ||
"wqkv": ["wqkv"], | ||
"qkv": ["qkv"], | ||
"gate_up_proj": [ | ||
"w1", | ||
"w3", | ||
], | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember these names are used by InternLM2. Dose this work for InternVL models with other backbones besides InternLM2 (like Qwen2.5)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably isn't supported
FIX #18820