Skip to content

[Misc] Split monolithic config.py into domain-specific modules #18830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented May 28, 2025

Background

Currently, the vLLM configuration is concentrated in a single large config.py containing over 5000 lines of code with multiple interconnected dataclasses. This monolithic structure has poor maintainability and readability, making it difficult for developers to locate, understand, and modify specific configurations.

Solution

This PR splits the monolithic configuration file into focused, domain-specific modules to improve code organization and developer experience.

|-- __init__.py
|-- cache_config.py
|-- compilation_config.py
|-- decoding_config.py
|-- device_config.py
|-- kvevents_config.py
|-- kvtransformer_config.py
|-- load_config.py
|-- lora_config.py
|-- model_config.py
|-- multimodal_config.py
|-- obervability_config.py
|-- parallel_config.py
|-- pass_config.py
|-- pooler_config.py
|-- promptadapter_config.py
|-- scheduler_config.py
|-- speculative_config.py
|-- tokenizerpool_config.py
|-- utils.py
|-- vllm_config.py

Signed-off-by: Jee Jee Li <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@jeejeelee jeejeelee requested a review from DarkLight1337 May 28, 2025 10:31
Copy link

mergify bot commented May 28, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @jeejeelee.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 28, 2025
Signed-off-by: Jee Jee Li <[email protected]>
@mergify mergify bot removed the needs-rebase label May 28, 2025
@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label May 28, 2025
Signed-off-by: Jee Jee Li <[email protected]>
Copy link

mergify bot commented May 28, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @jeejeelee.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 28, 2025
Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea to break a big file into smaller modules. One thing we may consider is the backward compatibility. Like we can import necessary modules in vllm/config/init.py, so we don't need to change imports like "from vllm.config import TaskOption, _get_and_verify_dtype"

Signed-off-by: Jee Jee Li <[email protected]>
@mergify mergify bot removed the needs-rebase label May 30, 2025
Copy link

mergify bot commented May 31, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @jeejeelee.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants