-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
[Misc] Split monolithic config.py into domain-specific modules #18830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jee Jee Li <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
This pull request has merge conflicts that must be resolved before it can be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea to break a big file into smaller modules. One thing we may consider is the backward compatibility. Like we can import necessary modules in vllm/config/init.py, so we don't need to change imports like "from vllm.config import TaskOption, _get_and_verify_dtype"
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
This pull request has merge conflicts that must be resolved before it can be |
Background
Currently, the vLLM configuration is concentrated in a single large config.py containing over 5000 lines of code with multiple interconnected dataclasses. This monolithic structure has poor maintainability and readability, making it difficult for developers to locate, understand, and modify specific configurations.
Solution
This PR splits the monolithic configuration file into focused, domain-specific modules to improve code organization and developer experience.