Skip to content

[WIP] Add a metric to track request failures #18765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

harche
Copy link

@harche harche commented May 27, 2025

Add a metric to track request failures

FIX #9346

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation frontend labels May 27, 2025
@harche harche force-pushed the failed_request_metric branch 3 times, most recently from dc482f1 to 9f9bf6d Compare May 27, 2025 16:26
@harche harche changed the title Add a metric to track request failures [WIP] Add a metric to track request failures May 27, 2025
@markmc
Copy link
Member

markmc commented May 28, 2025

Couple of points:

  • For new metrics, the priority should be to add them in V1 since V0 will shortly be deprecated
  • Are FINISHED_ABORTED requests already counted under request_success_total[length] ... is this counter poorly named and should be request_finished_total ?
  • Are failed HTTP requests already counted by the HTTP metrics middleware?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Usage]: Obtaining success / error rate % metrics
2 participants