-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
[Bugfix] Fix nomic max_model_len #18755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
I have written two examples of context_extension, but I don't know where the documentation should be placed. |
This is already the best I could do with the code and tests, this piece of code looks very funny. |
Is it possible to merge this fix before the v0.9.0 release? |
how about now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See if the test passes now
Thanks for reviewing |
Head branch was pushed to by a user without write access
FAILED models/language/pooling/test_gte.py::test_models_mteb[model_info9] - AssertionError should be fixed by #18747
|
because we did not use the nomic context extension method.
For nomic-ai/nomic-embed-text-v1, input length greater than 2048 will result nan,
For nomic-embed-text-v2-moe the length is set to 512 by sentence_bert_config.json.
context extension
offline
online