Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

According to vllm.EngineArgs, the name should be distributed_executor_backend #11689

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

chunyang-wen
Copy link
Contributor

@chunyang-wen chunyang-wen commented Jan 2, 2025

Fix the wrong argument name in doc.
in vllm.EngineArgs, the argument should be distributed_executor_backend instead of distributed-executor-backend.

Copy link

github-actions bot commented Jan 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Jan 2, 2025
@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 2, 2025
@comaniac comaniac enabled auto-merge (squash) January 2, 2025 16:58
@comaniac comaniac merged commit 84c35c3 into vllm-project:main Jan 2, 2025
45 of 46 checks passed
@chunyang-wen chunyang-wen deleted the update-arg-name branch January 3, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants