Skip to content

Conversation

@jikunshang
Copy link
Collaborator

@jikunshang jikunshang commented Sep 24, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS ABOVE HAVE BEEN CONSIDERED.

Purpose

we will always use develop install in ci to avoid python local first issue which may have conflicts in system path and delveop path for run pytest
update doc about build steps: prefer using pip install . instead of python setup.py install

Test Plan

Test Result

(Optional) Documentation Update

BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing (anything written below this line will be removed by GitHub Actions)

@Copilot Copilot AI review requested due to automatic review settings September 24, 2025 09:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a packaging issue where files in the vllm_xpu_kernels folder were not being included in the package distribution. The fix involves switching from automatic package discovery to explicit package specification and adding auto-imports for compiled extensions.

  • Switches from setuptools.packages.find to explicit packages configuration
  • Adds automatic imports for compiled C extensions (_C, _moe_C, _vllm_fa2_C, _xpu_C) in the package's __init__.py

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pyproject.toml Changes package discovery from find configuration to explicit packages list
vllm_xpu_kernels/init.py Adds imports for compiled C extension modules

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

where = ["."]
include = ["vllm_xpu_kernels*"]
[tool.setuptools]
packages = ["vllm_xpu_kernels"]
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explicit packages configuration may not include subdirectories or subpackages within vllm_xpu_kernels. Consider using find_packages() or explicitly listing all subpackages if they exist, or use packages = {"vllm_xpu_kernels": "vllm_xpu_kernels"} with include-package-data = true to ensure all necessary files are included.

Suggested change
packages = ["vllm_xpu_kernels"]
packages = "find:"
include-package-data = true

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

@baodii baodii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants