Enable AOT build for BMG, PVC #30
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enables Ahead-of-Time (AOT) compilation for SYCL GPU builds by adding configurable device target support with pvc and bmg as default targets.
- Adds AOT compilation configuration with performance optimization flags
- Replaces hardcoded SYCL link flags with configurable SYCL_LINK_OPTION variable
- Sets pvc and bmg as default AOT device targets
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| set(PERF_LINK_OPTS "${PERF_LINK_OPTS} -Xfinalizer -enableBCR") | ||
| set(PERF_LINK_OPTS "${PERF_LINK_OPTS} -Xfinalizer -DPASTokenReduction") | ||
|
|
||
| set(LINKE_OPTS ${LINKE_OPTS} |
There was a problem hiding this comment.
Variable name 'LINKE_OPTS' contains a typo. It should be 'LINK_OPTS' for consistency and clarity.
| set(LINKE_OPTS ${LINKE_OPTS} -fsycl-targets=spir64_gen) | ||
| endif() | ||
|
|
||
| set(LINKE_OPTS ${LINKE_OPTS} -Xs ) |
There was a problem hiding this comment.
There's a trailing space after '-Xs' which could cause issues. Remove the trailing space or add a comment explaining why it's needed.
| set(LINKE_OPTS ${LINKE_OPTS} -Xs ) | |
| set(LINKE_OPTS ${LINKE_OPTS} -Xs) |
CMakeLists.txt
Outdated
| set(VLLM_EXTRA_INCLUDE_DIRECTORIES ${CMPLR_ROOT}/include/sycl) | ||
| list(APPEND VLLM_GPU_FLAGS "-DVLLM_BUILD_XPU_OPS" ) | ||
| list(APPEND VLLM_GPU_LINK_FLAGS "-fsycl" "-fsycl-targets=spir64") | ||
| list(APPEND VLLM_GPU_FLAGS "-DVLLM_BUILD_XPU_OPS" -fsycl-targets=spir64_gen,spir64 ) |
There was a problem hiding this comment.
The compiler flag '-fsycl-targets=spir64_gen,spir64' is hardcoded here but AOT configuration is handled elsewhere. Consider using the same configurable approach for consistency.
jikunshang
force-pushed
the
enable_aot
branch
from
42910ec to
c6fc1f7
Compare
jikunshang
force-pushed
the
enable_aot
branch
from
c6fc1f7 to
d3b110d
Compare
updated. |
Signed-off-by: Kunshang Ji <[email protected]>
Signed-off-by: Kunshang Ji <[email protected]>
Signed-off-by: Kunshang Ji <[email protected]>
2 participants
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS ABOVE HAVE BEEN CONSIDERED.
Purpose
add pvc,bmg as default AOT build target. currently, we only enable bmg and pvc.
will add more xe3 aot options in the future, limited xe3 arch supported in ocloc 1146.
how to check supported aot option:
ocloc ids -hTest Plan
Test Result
(Optional) Documentation Update
BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing (anything written below this line will be removed by GitHub Actions)