Skip to content

Conversation

wallashss
Copy link
Collaborator

Fix #45

I created a new file that we can import the needed classes from vllm and it solves depending the installed version (for backward compatibility).

I also did some changes that are only related to TYPE_CHECKING

Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes:

pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

Copy link
Collaborator

@joerunde joerunde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPGTM, thanks!

Personally I would slightly prefer following the if/else pattern on type checking so that we can use the real types in the hints, just because my VSCode happens to like that better

@wallashss
Copy link
Collaborator Author

HMMMM interesting!

Personally I would slightly prefer following the if/else pattern on type checking so that we can use the real types in the hints, just because my VSCode happens to like that better

I'll gonna do that now. Wait a sec.

Signed-off-by: Wallas Santos <[email protected]>
@wallashss
Copy link
Collaborator Author

Done @joerunde

@joerunde
Copy link
Collaborator

nice!

@joerunde joerunde merged commit e168907 into vllm-project:main Mar 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[V1] Update to the new scheduler interface

2 participants