-
Notifications
You must be signed in to change notification settings - Fork 26
📜 Add documentation and diagrams on the plugin architecture #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Max de Bayser <[email protected]>
👋 Hi! Thank you for contributing to vLLM support on Spyre.
Or this can be done with
Now you are good to go 🚀 |
Signed-off-by: Max de Bayser <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just a couple of typos and some recommendations for conciseness.
Co-authored-by: Rafael Vasquez <[email protected]> Signed-off-by: Maximilien de Bayser <[email protected]>
Co-authored-by: Rafael Vasquez <[email protected]> Signed-off-by: Maximilien de Bayser <[email protected]>
Co-authored-by: Rafael Vasquez <[email protected]> Signed-off-by: Maximilien de Bayser <[email protected]>
Co-authored-by: Rafael Vasquez <[email protected]> Signed-off-by: Maximilien de Bayser <[email protected]>
Co-authored-by: Rafael Vasquez <[email protected]> Signed-off-by: Maximilien de Bayser <[email protected]>
Signed-off-by: Max de Bayser <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description
Add documentation on how the plugin fits into the vLLM architecture.