Skip to content

Conversation

maxdebayser
Copy link
Collaborator

Description

Add documentation on how the plugin fits into the vLLM architecture.

Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

Signed-off-by: Max de Bayser <[email protected]>
Copy link
Collaborator

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a couple of typos and some recommendations for conciseness.

maxdebayser and others added 6 commits October 15, 2025 13:52
Co-authored-by: Rafael Vasquez <[email protected]>
Signed-off-by: Maximilien de Bayser <[email protected]>
Co-authored-by: Rafael Vasquez <[email protected]>
Signed-off-by: Maximilien de Bayser <[email protected]>
Co-authored-by: Rafael Vasquez <[email protected]>
Signed-off-by: Maximilien de Bayser <[email protected]>
Co-authored-by: Rafael Vasquez <[email protected]>
Signed-off-by: Maximilien de Bayser <[email protected]>
Co-authored-by: Rafael Vasquez <[email protected]>
Signed-off-by: Maximilien de Bayser <[email protected]>
Signed-off-by: Max de Bayser <[email protected]>
@maxdebayser maxdebayser requested a review from rafvasq October 15, 2025 16:55
Copy link
Collaborator

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@maxdebayser maxdebayser merged commit 5e8a8ed into main Oct 16, 2025
19 checks passed
@maxdebayser maxdebayser deleted the arch_docs branch October 16, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants