Skip to content

Conversation

joerunde
Copy link
Collaborator

@joerunde joerunde commented Oct 7, 2025

Description

This PR fixes a bug where the test collection failed on the full-sized models because we injected a string instead of a ModelInfo for the model param. This both:

  1. Updates the full-sized model parameterization to use a ModelInfo with a pinned revision
  2. Updates the test collection code to not fail if a string is passed anyway

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

Copy link
Collaborator

@maxdebayser maxdebayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joerunde joerunde merged commit a8a857f into main Oct 7, 2025
19 checks passed
@joerunde joerunde deleted the fix-full-models branch October 7, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants