Skip to content

Conversation

joerunde
Copy link
Collaborator

@joerunde joerunde commented Oct 3, 2025

I noticed that this test ends up in both the static and continuous batching runs because it's automatically parametrized both ways with the unused warmup_shapes and cb parameters. This should fix that so it only runs in the continuous batching suite

Copy link

github-actions bot commented Oct 3, 2025

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

Signed-off-by: Joe Runde <[email protected]>
Copy link
Collaborator

@maxdebayser maxdebayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joerunde joerunde merged commit 33872d0 into main Oct 6, 2025
18 checks passed
@joerunde joerunde deleted the lil-test-cleanup branch October 6, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants