[DON'T MERGE] <[CI Test]> Don't use cache for 4-layer granite model (PR #497) #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
ckadner
requested review from
joerunde,
prashantgupta24,
rafvasq and
sducouedic
as code owners
Signed-off-by: Christian Kadner <[email protected]>
.github/workflows/test.yml
Outdated
| - name: "Restore HF models cache" | ||
| id: cache_restore | ||
| if: steps.changed-src-files.outputs.any_changed == 'true' | ||
| if: ! contains(env.model_key, 'micro') |
There was a problem hiding this comment.
Okay I think I see what you're trying to do here
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
|
Going to push commits to this PR to test the model.revision bug fixes! |
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Cool! All tests green 💯 |
|
So my plan at this time is to open a new PR with the latest commits from this PR which fix the model revision used in the tests. Once we get that in then we can discuss about whether we even want to revert to the 3 layer model or not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Draft PR #497 has all tests pass because it uses both tiny granite models
This PR checks the test results for bypassing the cache (not using 4-layer model)
Related Issues
#497