-
Notifications
You must be signed in to change notification settings - Fork 26
WIP: GHA test with model revisions #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
.github/workflows/test.yml
Outdated
download_tinygranite() { | ||
python -c "from transformers import pipeline, AutoTokenizer; pipeline('text-generation', model='$1'); tokenizer=AutoTokenizer.from_pretrained('$1')" | ||
download_granite_or_llama() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all of this can be simplified to a single function like:
from transformers import pipeline
from sentence_transformers import SentenceTransformer
try:
pipeline(model='$1', revision='$2')
except RuntimeError:
SentenceTransformer('$1', revision='$2')
I'd be fine sticking that in a script that we keep around here in the .github/workflows
folder.
python3 ./just_download_the_dang_model.py --model foo --revision bar
That should get rid of a lot of the complexity here. Otherwise these changes all look great to me- putting the revisions in the cache key and splitting out the multi-model cases to have individual cache entries is exactly what we want. Sure hf_model_2
is a little wonky but I can live with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ #523
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Need to rebase this PR onto main (currently it's based on top of Prashant's branch) |
Signed-off-by: Christian Kadner <[email protected]>
Closing this. Changes from this PR are rebased onto |
Description
Cache models with revision for GitHub Action test runs.
TODOs:
--> [CI] Enable model revisions in GHA test #523
revision: main
)https://github.com/vllm-project/vllm-spyre/actions/runs/18189810233/job/51782179337?pr=499#step:14:258
Related Issues
#497