-
Notifications
You must be signed in to change notification settings - Fork 26
feat: add VLLM_SPYRE_NUM_CPUS and psutil to help with cpu checks #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to vLLM support on Spyre.
Or this can be done with
Now you are good to go 🚀 |
2b5b5a6
to
012e17b
Compare
012e17b
to
8db58b6
Compare
f"Detected {cpu_count} CPUs from " \ | ||
"psutil.cpu_count(logical=False)" | ||
except ImportError: | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we log here saying that psutil can be used if it's installed?
I'm also not opposed to adding it as a dependency, it seems very well maintained
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is well maintained, but is also OS-dependent compiled code. We could list out all of the platform_system
s it does support, but 🤷. I wish there was a configuration like "try to install by default but don't stop the install if unable" 😅
I'll add a log message indicating the option to install it though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, perhaps that's a better option since we have to support non x86 platforms.
bot:test |
Signed-off-by: Travis Johnson <[email protected]>
Signed-off-by: Travis Johnson <[email protected]>
Signed-off-by: Travis Johnson <[email protected]>
Signed-off-by: Travis Johnson <[email protected]>
c79c32f
to
e6891d1
Compare
The |
bot:test |
Description
A couple of improvements related to setting threading based on cpu count:
VLLM_SPYRE_NUM_CPUS
configuration to set the cpu count and skip the detection stepspsutil
as another way to auto-detect CPUs by counting "physical" cores only instead of logical coresfp8
extras package)Related Issues
#483