[WIP][CB][FP8] fix batch size 1 #466
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CB][FP8] fix batch size 1
We require an effective batch size of >= 2 for warmup and decodes when running fp8 continuous batching. This PR allows
--max_num_seqs 1
still to be set and served.As we pad single sequences, which may also occur when serving
--max_num_seqs>=2
, to batch size 2 anyway, the only change needed was to have the input_batch hold two sequences for warmup.We had the exact same issue for fp16 in the past, see #347 and #312
UPDATE: upstream logic has changed since, fix is more involved. De-prioritizing this and throw an error instead (#467)